Repository navigation
fix: a new app passes its own static analysis, and CI keeps it so - #168
Merged
rodrigoteamx merged 2 commits intoOct 10, 2026
Merged
rodrigoteamx merged 2 commits into
rodrigoteamx merged 2 commits into
Conversation
…rpose The skeleton ships PHPStan and a config (level 6 over src, public and config) and no workflow ran it. Both create-project houses CI already bears — the fresh one and the one that enabled its capabilities — are now analysed with the house's own config. This commit adds only the guard. It is red today: public/worker.php carries a guard for a runtime below the skeleton's own floor, and PHPStan says so. The next commit removes it.
… below the floor is gone public/worker.php guarded its question to the kernel definition with method_exists(), for a runtime older than 0.197. The skeleton's floor is >=0.198: the guard could never be false, and PHPStan said so on every new app. It asks directly now. No definition at all — the include failed — is still the one case that cannot be asked, and the worker still leaves then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new app did not pass its own static analysis. With the skeleton's own
phpstan.neon(level 6 oversrc,publicandconfig):The guard was for a runtime older than 0.197; the skeleton's floor is
>=0.198 <1.0. It was dead.Why nobody saw it: the skeleton ships
phpstan/phpstanand a config, and no workflow ran it.What changes
create-projecthouses CI already bears: the fresh one, and the one that enabled its capabilities (which writesconfig/operations.phpandconfig/plugins.php, read by the same config).The control, by execution
The first commit of this pull request adds only the CI step: it is red, on the line above. The second removes the guard: green. Measured on fresh cattle too, with no model (greenhouse
evidence/1187): both houses exit 1 with one error before, 0 after.No published contract changes:
public/worker.phpasks the same question of the same method.