Skip to content

chore: publish Quickstarts for SDK version 5.1.0 - #312

Merged
Kristopher Johnson (kristopherjohnson) merged 3 commits into
mainfrom
quickstart-publish/5.1.0
Sep 18, 2026
Merged

Kristopher Johnson (kristopherjohnson) merged 3 commits into
mainfrom
quickstart-publish/5.1.0

Conversation

@ditto-sdk-releases

Copy link
Copy Markdown
Contributor

Publishes the Quickstart apps for SDK version 5.1.0. Opened automatically by the Quickstart Publish workflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile and Python dependency configuration do not consistently target SDK 5.1.0, and documented commands use unpinned dependencies.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Publishes the Python TUI Quickstart for SDK 5.1.0 and updates documentation and tooling.

Changes:

  • Adds the Python TUI task application, packaging, and smoke test.
  • Documents setup and usage.
  • Registers the quickstart and adds Just recipes.
  • Updates Rust lockfile metadata.
File summaries
File Summary
rust-tui/Cargo.lock Lockfile still resolves Ditto SDK 5.0.3 instead of 5.1.0. Critical, 3 votes.
README.md Adds the Python TUI quickstart to the repository listing.
python-tui/README.md Documents setup and usage, but three commands use an unpinned SDK. Moderate, 1 vote each.
python-tui/pyproject.toml Dependency excludes SDK 5.1.0 and resolves a 5.2.0 development-or-newer package. Moderate, 3 votes.
python-tui/main.py Temporary directories are not cleaned up after execution. Moderate, 1 vote.
python-tui/.gitignore Adds Python and local runtime ignore rules.
justfile Run and smoke-test commands use an unpinned SDK dependency. Moderate, 2 votes.
Review details

Suppressed comments (5)

justfile:58

  • The smoke recipe also installs an unversioned SDK, making the advertised self-test non-reproducible and potentially testing a different API than the 5.1.0 quickstart. Pin this --with requirement to dittolive-ditto==5.1.0.
        uv run --with dittolive-ditto main.py --smoke

python-tui/README.md:50

  • This command bypasses pyproject.toml and asks uv to resolve an unpinned SDK, so the documented recommended setup can run a different version than the 5.1.0 quickstart (and can ignore the project pin when it is corrected). Pin the requirement in this command, or run the project with uv run main.py.
uv run --with dittolive-ditto main.py

python-tui/README.md:61

  • The pip alternative is also unpinned, so following this documented installation path can install a newer or incompatible SDK instead of the 5.1.0 version published by this PR.
pip install dittolive-ditto

python-tui/README.md:99

  • The self-test command repeats the unpinned --with install, so it is not guaranteed to exercise the SDK version published by this PR. Pin the requirement here as well, or invoke the project dependency with uv run main.py --smoke.
uv run --with dittolive-ditto main.py --smoke

python-tui/main.py:124

  • A new directory is created for every invocation and the process never removes it; tempfile.mkdtemp does not guarantee OS cleanup at process exit, so repeated runs accumulate SDK databases and rotating logs under the system temp directory. Clean the directory at a safe shutdown point or prune stale ditto-python-tui-* directories.
    persistence_directory = tempfile.mkdtemp(prefix="ditto-python-tui-")
  • Files reviewed: 6/7 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread justfile Outdated
Comment thread python-tui/pyproject.toml
Pin the dittolive-ditto version in pyproject.toml and remove --with dittolive-ditto where it doesn't belong to make managing the ditto version easier.
Removed unnecessary '--with dittolive-ditto' option from uv run commands in README.
@kristopherjohnson
Kristopher Johnson (kristopherjohnson) merged commit d67746b into main Sep 18, 2026
1 check passed
@kristopherjohnson
Kristopher Johnson (kristopherjohnson) deleted the quickstart-publish/5.1.0 branch September 18, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants