Repository navigation
chore: publish Quickstarts for SDK version 5.1.0 - #312
Merged
Kristopher Johnson (kristopherjohnson) merged 3 commits intoSep 18, 2026
Merged
Conversation
Ditto SDK Releases (ditto-sdk-releases)
requested a review
from a team
as a code owner
September 18, 2026 17:41
Ditto SDK Releases (ditto-sdk-releases)
requested review from
Ricky Padilla (rickypadilla-ditto)
and removed request for
a team
September 18, 2026 17:41
Copilot started reviewing on behalf of
Ditto SDK Releases (ditto-sdk-releases)
September 18, 2026 17:42
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile and Python dependency configuration do not consistently target SDK 5.1.0, and documented commands use unpinned dependencies.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Publishes the Python TUI Quickstart for SDK 5.1.0 and updates documentation and tooling.
Changes:
- Adds the Python TUI task application, packaging, and smoke test.
- Documents setup and usage.
- Registers the quickstart and adds Just recipes.
- Updates Rust lockfile metadata.
File summaries
| File | Summary |
|---|---|
rust-tui/Cargo.lock |
Lockfile still resolves Ditto SDK 5.0.3 instead of 5.1.0. Critical, 3 votes. |
README.md |
Adds the Python TUI quickstart to the repository listing. |
python-tui/README.md |
Documents setup and usage, but three commands use an unpinned SDK. Moderate, 1 vote each. |
python-tui/pyproject.toml |
Dependency excludes SDK 5.1.0 and resolves a 5.2.0 development-or-newer package. Moderate, 3 votes. |
python-tui/main.py |
Temporary directories are not cleaned up after execution. Moderate, 1 vote. |
python-tui/.gitignore |
Adds Python and local runtime ignore rules. |
justfile |
Run and smoke-test commands use an unpinned SDK dependency. Moderate, 2 votes. |
Review details
Suppressed comments (5)
justfile:58
- The smoke recipe also installs an unversioned SDK, making the advertised self-test non-reproducible and potentially testing a different API than the 5.1.0 quickstart. Pin this
--withrequirement todittolive-ditto==5.1.0.
uv run --with dittolive-ditto main.py --smoke
python-tui/README.md:50
- This command bypasses
pyproject.tomland asks uv to resolve an unpinned SDK, so the documented recommended setup can run a different version than the 5.1.0 quickstart (and can ignore the project pin when it is corrected). Pin the requirement in this command, or run the project withuv run main.py.
uv run --with dittolive-ditto main.py
python-tui/README.md:61
- The pip alternative is also unpinned, so following this documented installation path can install a newer or incompatible SDK instead of the 5.1.0 version published by this PR.
pip install dittolive-ditto
python-tui/README.md:99
- The self-test command repeats the unpinned
--withinstall, so it is not guaranteed to exercise the SDK version published by this PR. Pin the requirement here as well, or invoke the project dependency withuv run main.py --smoke.
uv run --with dittolive-ditto main.py --smoke
python-tui/main.py:124
- A new directory is created for every invocation and the process never removes it;
tempfile.mkdtempdoes not guarantee OS cleanup at process exit, so repeated runs accumulate SDK databases and rotating logs under the system temp directory. Clean the directory at a safe shutdown point or prune staleditto-python-tui-*directories.
persistence_directory = tempfile.mkdtemp(prefix="ditto-python-tui-")
- Files reviewed: 6/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pin the dittolive-ditto version in pyproject.toml and remove --with dittolive-ditto where it doesn't belong to make managing the ditto version easier.
Removed unnecessary '--with dittolive-ditto' option from uv run commands in README.
Kristopher Johnson (kristopherjohnson)
approved these changes
Sep 18, 2026
Kristopher Johnson (kristopherjohnson)
deleted the
quickstart-publish/5.1.0
branch
September 18, 2026 19:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes the Quickstart apps for SDK version 5.1.0. Opened automatically by the Quickstart Publish workflow.