Skip to content

fix: CI failures and disable unused workflows - #98

Merged
rolznz merged 2 commits into
getAlby:mainfrom
rolandgx:fix/ci
Oct 15, 2026
Merged

rolznz merged 2 commits into
getAlby:mainfrom
rolandgx:fix/ci

Conversation

@rolandgx

@rolandgx rolandgx commented Oct 15, 2026 •

Copy link
Copy Markdown

Fixes the failing GitHub Actions on main:

  • CI Checks - Rust Tests: failed at the cargo fmt --check step (src/lib.rs, src/liquidity.rs). Ran cargo fmt.
  • CI Checks - VSS Integration Tests: io::vss_store tests failed to compile because VssStore::new now takes the Alby secondary_kv_store argument. The tests now pass an InMemoryStore.
  • SemVer checks: disabled (now workflow_dispatch only). The fork intentionally adds API on top of upstream (e.g. new Error variants), so comparing against the upstream crates.io release always fails, and we don't publish this crate.
  • CI Checks - Swift Tests: disabled (now workflow_dispatch only), since we only compile for Alby Hub, not mobile.

LND Integration Tests failed on an earlier commit but pass on current main, so no change was needed there.

Verified locally: cargo fmt --check, cargo build / --features uniffi / check --release with -D warnings, lib unit tests, and the VSS tests compile with --cfg vss_test. Integration tests weren't run locally (arm64 machine), so this PR's CI covers them.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • SemVer and Swift workflows now run only when manually triggered; they no longer run automatically on pushes or pull requests.
  • Tests
    • Updated persistence tests to provide the required secondary store.
    • Adjusted an expected inbound payment count to reflect additional test payments.

- Run cargo fmt (fixes Rust Tests formatting check)
- Pass the Alby secondary KV store to VssStore::new in vss_store tests
  (fixes VSS Integration Tests compile error)
- Disable Swift tests: we only compile for Alby Hub, not mobile
- Disable SemVer checks: the fork intentionally extends the upstream API,
  so checks against the upstream crates.io release always fail

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f9f1532e-649f-476f-a5b8-c619770a4b47
📥 Commits

Reviewing files that changed from the base of the PR and between aa73247 and 18cb185.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 6
  • .github/workflows/semver.yml
  • .github/workflows/swift.yml
  • src/io/vss_store.rs
  • src/lib.rs
  • src/liquidity.rs
  • tests/common/mod.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The SemVer and Swift workflows now run only when manually triggered. VSS persistence tests pass an in-memory secondary store to the constructor. The changes also update a BOLT11 payment-count assertion, reposition a public re-export, and reformat liquidity code.

Changes: Workflow triggers

Layer / File(s) Summary
Manual workflow dispatch
.github/workflows/semver.yml, .github/workflows/swift.yml
Both workflows replace automatic push and pull-request triggers with manual dispatch. Comments document the stated reasons and note that manual runs remain available.

Rust source and test updates

Layer / File(s) Summary
VSS persistence test setup
src/io/vss_store.rs
Both persistence tests create an InMemoryStore and pass it as the fifth argument to VssStore::new.
Payment-count assertion
tests/common/mod.rs
The expected inbound BOLT11 payment count for node B changes from 6 to 8. A comment attributes the two additional payments to invoices created with minimum CLTV expiry deltas.
Liquidity export and formatting
src/lib.rs, src/liquidity.rs
The lsps2_compute_opening_fee_msat re-export moves beside the liquidity imports. The liquidity constructor parameters and runtime call are reformatted without behavior changes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: tnull

Merge Risk: ⚪ Minimal · up to 18cb1

No actionable merge-blocking risk is established; the change is ready to merge after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately summarizes the main changes: it addresses CI failures and disables workflows that do not apply to the fork.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.1)

Clippy execution timed out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…e payment count

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rolznz

rolznz commented Oct 15, 2026

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@rolznz
rolznz merged commit 553a210 into getAlby:main Oct 15, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants