Repository navigation
fix: CI failures and disable unused workflows - #98
Conversation
- Run cargo fmt (fixes Rust Tests formatting check) - Pass the Alby secondary KV store to VssStore::new in vss_store tests (fixes VSS Integration Tests compile error) - Disable Swift tests: we only compile for Alby Hub, not mobile - Disable SemVer checks: the fork intentionally extends the upstream API, so checks against the upstream crates.io release always fail Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
…e payment count Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Fixes the failing GitHub Actions on
main:cargo fmt --checkstep (src/lib.rs,src/liquidity.rs). Rancargo fmt.io::vss_storetests failed to compile becauseVssStore::newnow takes the Albysecondary_kv_storeargument. The tests now pass anInMemoryStore.workflow_dispatchonly). The fork intentionally adds API on top of upstream (e.g. newErrorvariants), so comparing against the upstream crates.io release always fails, and we don't publish this crate.workflow_dispatchonly), since we only compile for Alby Hub, not mobile.LND Integration Tests failed on an earlier commit but pass on current
main, so no change was needed there.Verified locally:
cargo fmt --check,cargo build/--features uniffi/check --releasewith-D warnings, lib unit tests, and the VSS tests compile with--cfg vss_test. Integration tests weren't run locally (arm64 machine), so this PR's CI covers them.🤖 Generated with Claude Code
Summary by CodeRabbit