Repository navigation
fix(staking): epoch-0 stake status, identity signer and wizard operator checks - #429
Merged
Merged
Conversation
…or checks Epoch 0: - The contract writes epoch-0 deposits straight into vStake, so validator-info, stake-info and validators no longer list them as pending "activates at epoch 2". - The epoch-0 note only says "won't become active" when self-stake is below the minimum. - A funded validator at epoch 0 shows as pending (nobody is active until the epoch advances). - Deposit pre-checks no longer count epoch-0 deposits twice. Identity: - set-identity --account help says owner (the wallet is Ownable), and the help notes that each call replaces the whole identity. - validator-guide: sign with the owner, vesting route, overwrite behaviour, and the operator must be a CLI account. Wizard: - An entered operator address (prompt or --operator) must be a CLI account and is checked at once, not after every prompt. - A browser-wallet owner can't be its own operator (no key to sign the proof). - The summary prints validator-info <wallet> --network <alias> and the node import command. - The network prompt defaults to testnet-bradbury. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
/run-e2e |
Contributor
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes problems found while checking the validator join flow against the contracts (genlayer-consensus
v0.6-rc-1, f8eb64a) and live Bradbury, which is still in epoch 0.Epoch-0 stake status (
validator-info,validators, stake info)In epoch 0 the contract writes deposits straight into the active stake record (
ValidatorUtils.validatorDepositEpoch0,DelegatorUtils.delegatorJoinEpoch0). The CLI applied its "+2 epochs" rule to them anyway. On Bradbury today, both joined validators showed:Now:
staking/epochTiming.ts);pendinginvalidators, because nobody is active until the epoch advances;validator-depositandvesting validator depositminimum-stake checks no longer count epoch-0 deposits twice.Identity
set-identity --accounthelp said "must be validator operator".setIdentityisonlyOwner, so it now says owner.docs/validator-guide.md:vesting validator set-identity;Wizard (
staking wizard)--operator) must be a CLI account, because the CLI signs its proof of possession. This is now checked when the address is entered, not at the join step after every prompt.--operator-sameis rejected with a clear message.validator-info <wallet> --network <alias>instead of the deprecated--validatorflag, plus thegenlayernode account importstep and a docs link.testnet-bradburyinstead of the retiredtestnet-asimov.docs/validator-guide.mdno longer says an existing geth/foundry operator address can be used directly.Test plan
npx vitest run: 840 passed, with new tests for each fixnpx tsc --noEmit: only the existingtests/actions/stakingWizard.test.ts(83,23)TS2352validator-info 0x1404…3A1D: pending depositsNone, and the note says the minimum is metvalidators: both validatorspending/run-e2e all🤖 Generated with Claude Code