Repository navigation
Android: Store a WalletConnect connection for the wallet that approved it - #1670
Merged
Merged
Conversation
…d it When a second connection was approved before the first dApp confirmed its own, the first connection was saved under the second wallet, so its requests opened under the wrong wallet. 1. A pending approval is remembered by the accounts it grants, and the dApp's confirmation is matched back to it. 2. One-click sign-in keeps storing the session it creates. 3. The coordinator no longer reads the connection store directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two WalletConnect connections were approved close together on Android, the first dApp could be saved under the second wallet, so its requests opened under the wrong wallet. iOS already saves each connection under the wallet it was approved with.
Each approval now keeps the wallet it was made with until the dApp confirms the connection, and one-click sign-in stores its session the same way as before. The coordinator no longer reads the connection store directly, and the product page records the rule.