Repository navigation
Remove extract-zip from the Puppeteer dependency chain - #1627
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puppeteer 25.13.0 removes the flagged extract-zip dependency from the browser installer. Refs #1625.
This update requires Node.js 22.12.0 or newer. Upgrade Node.js before installing it. Docker and Travis now use Node 22. Review screenshot differences before approving new references.
Existing ignoreHTTPSErrors and headless settings still work. node-fetch is now a direct dependency because the shipped CSP helper uses it.
npm ci, lint, 31 unit tests and the report build pass. Three unit tests remain pending. The default reference test passes both viewports. With local fonts supplied, the feature comparison passed 62 images and failed one click snapshot. The smoke script hides failures in its exit status. npm audit no longer flags extract-zip or Puppeteer. It still reports 52 other findings.
The click mismatch also occurs on unchanged master. I have left this unmerged because checks still fail and GitHub workflows need Node 22. No version bump or release is included.