Skip to content

Implement changes defined in ADR034 and 035 - #393

Draft
NotTheEvilOne wants to merge 3 commits into
mainfrom
feature/adr34
Draft

NotTheEvilOne wants to merge 3 commits into
mainfrom
feature/adr34

Conversation

@NotTheEvilOne

@NotTheEvilOne NotTheEvilOne commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR implements changes required to suit ADR034 and 035.

Main changes

  • Implementation of ADR 034 and 035. This requires renaming and introducing inherited classes for Flavor, VersionedFlavor and ArtifactBaseName in gardenlinux.features`.
  • Fixing sorting of feature lists for flavors.yaml parser in gardenlinux.flavors.Parser
  • Changes to various classes utilizing gardenlinux.features
  • Implement changed naming to gl-features-parse and remove shortcut command line tool gl-cname.

Which issue(s) this PR fixes:
Fixes #376
Fixes #377
Requires #390

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: <tobias.wolf@sap.com>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>
@NotTheEvilOne
NotTheEvilOne force-pushed the feature/adr34 branch 4 times, most recently from 82428ae to 0efc342 Compare September 18, 2026 12:06
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.84540% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.13%. Comparing base (acc50b5) to head (d710296).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/features/artifact_base_name.py 85.61% 21 Missing ⚠️
src/gardenlinux/features/__main__.py 82.55% 15 Missing ⚠️
src/gardenlinux/s3/s3_artifacts.py 65.00% 7 Missing ⚠️
src/gardenlinux/features/c_name.py 93.02% 6 Missing ⚠️
src/gardenlinux/oci/container.py 66.66% 4 Missing ⚠️
src/gardenlinux/features/parser.py 88.88% 2 Missing ⚠️
src/gardenlinux/features/metadata_main.py 96.29% 1 Missing ⚠️
src/gardenlinux/oci/image_manifest.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   91.28%   91.13%   -0.15%     
==========================================
  Files          49       51       +2     
  Lines        2971     3002      +31     
==========================================
+ Hits         2712     2736      +24     
- Misses        259      266       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NotTheEvilOne
NotTheEvilOne force-pushed the feature/adr34 branch 12 times, most recently from a26a1f3 to d048301 Compare September 28, 2026 15:22
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: <tobias.wolf@sap.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align cname and flavor handling with ADR 0035 Align platform resolution with ADR 0034

1 participant