Repository navigation
feat(check): size runtime by missing snapshots - #152
Merged
Merged
Conversation
`check` reported as total_runtime_size the runtime size of the blobs missing from the store. With the images installed into containerd that is wrong both ways: a reinstall after a prune reported 0 though every layer is unpacked again, a shared base whose blob is missing but whose snapshot exists was counted though nothing is unpacked, and a resumed install unpacks only the layers from its first missing snapshot on. On a containerd install target `check` now sizes the layers by the snapshots: in each image, the layer of the first missing snapshot and every layer above it, each chain ID once across the images, with the same snapshot scan the install uses. An image whose manifest or config cannot be read counts all its layers. Other blobs keep the old rule, and a `docker load` daemon is sized as before. `pull` checks its free space with the same sizing, so it no longer fetches apps whose unpacking cannot fit. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Mike Sul <mike.sul@foundries.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a dockerd with the containerd image store,
checkandpullnow size the runtime by the layers whose snapshot is missing, not by the blobs missing from the store. A reinstall after an image prune is no longer reported as needing nothing, and layers already unpacked are no longer counted.Test:
TestCtrdCheckSizesByMissingSnapshotsandTestCtrdCheckSizesImageWithMissingConfigin the e2e suite withCONTAINERD_SNAPSHOTTER=true.