Repository navigation
lint: fix the issues golangci-lint v2.14.0 reports on draft-22 - #122
Merged
Merged
Conversation
The Lint job has failed on every push since 835f6db, and every PR against draft-22 inherits it (e.g. dependabot #121). Nine issues, all from 835f6db..85049b6: - golines/goimports: wrap four long lines; move "bytes" into the stdlib import group in metrics_test.go - embeddedstructfieldcheck: blank line after the embedded field in prioritizedSendStream and deadlineRecordingSendStream - modernize embedlit: set the promoted field directly in wrapSendStream's prioritizedSendStream literal - revive unused-parameter: blockedSendStream.Write ignores its input No behavior change. Lint-only, so there is no regression test; the Lint job itself is the check that goes red without this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lint job has failed on every push to
draft-22since 835f6db, so every PR against it inherits the failure. Dependabot's #121 is one example: its dependency bumps are fine.Nine issues, all introduced in 835f6db..85049b6:
handler_fanout.go,metrics_test.go,urgency_test.go,datastream_timeout_test.go) and move"bytes"into the stdlib import group inmetrics_test.goprioritizedSendStream(wtconn) anddeadlineRecordingSendStream(a test helper)&prioritizedSendStream{s: s, p: p}, setting the promoted field directly, as Go 1.27 allowsblockedSendStream.Write([]byte), unnamed likefailingWriteStreamin the registry testsNo behavior change. The
handler_fanout.goedit only re-wraps a line on the per-object path, so I didn't rerun the benchmarks. There's no regression test because the Lint job is itself the check that goes red without this.Verified locally: golangci-lint v2.14.0 (the version CI pins) reports 0 issues,
go build ./...passes,go test -race ./pkg/moqt/session/... ./pkg/relay/...passes, and moqt-reviewer found nothing.Note: golangci-lint v2.13.x cannot typecheck under go1.27.2 ("export data version 5"), so a stale local install fails every package and hides these issues.
After this merges,
@dependabot rebaseon #121 should turn it green.🤖 Generated with Claude Code