Repository navigation
Conversation
osantana85
requested changes
Nov 5, 2026
|
|
||
| logger.info("Backfilling audit history into journal streams"); | ||
| this.persistenceFactory = persistenceFactory; | ||
| for (AuditEntry auditEntry : persistenceFactory.get(SYSTEM_STAGE_ID).getAuditHistory()) { |
Member
There was a problem hiding this comment.
I think that David's comment is not solved in PR #986, or at least not the expecting change. I think the comment was related to get the persistence instance shared from the same map. In this line you are getting an instance directly from the persistenceFactory, without asking for an instance in the existing map (at this moment we know that the map will be empty, but we should add the instance to it allowing next access to be present and don't instanciate another instance for the same stage id).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JournalBackfillChangeto copy historical audit entries into journal streams without modifying audit history; registration and execution ordering remain outside this change.Testing