Repository navigation
fix(setup): install the Alexandria skill with the core skills - #310
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
… fallback Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes firecrawl setup so the Alexandria skill installs with the default core skills, routes setup alexandria through the normal catalog installer instead of the deleted beta-skills path, and hardens npx invocation to use argv; tests cover the new behavior.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes setup so the Alexandria skill installs with the core CLI skill set, routes setup alexandria through the normal catalog installer, and hardens npx invocation to use argv; tests pin the corrected behavior.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Tip: Review your code locally with the cubic CLI to iterate faster.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes CLI skill setup so firecrawl-alexandria ships with the core set, removes the broken setup alexandria path, and invokes npx via argv without a shell; tests pin the corrected behavior.
View guided diff | Turn on auto-fix | Re-trigger cubic
Problem
firecrawl-alexandrialives inskills/and is mirrored tofirecrawl/skillsunderskills/core/, but it isn't inCLI_SKILLS. Sofirecrawl initandfirecrawl setup corenever install it. Thefirecrawl,firecrawl-searchandfirecrawl-scrapeskills all link to../firecrawl-alexandria/SKILL.mdfor Alexandria feedback, and on a user's machine that link points to nothing.That skill is the only place that tells a CLI agent to send
firecrawl alexandria feedback, explains the 1-credit refund, and describes the feedback fields. CLI agents send many feedback reports per team but have the highestbadshare of any surface, so the coverage signal from the CLI is thinner than it should be.firecrawl setup alexandriawas broken too. It installs from../../beta-skills, which #271 deleted, and that folder was never part of the npmfileslist anyway.Change
firecrawl-alexandriatoCLI_SKILLS, soinitandsetup coreinstall it next to the search/scrape skills that point to it.setup alexandriacommand (it installed from the deletedbeta-skills/).firecrawl-alexandrianow ships with the core skills instead.installSkillsnow runsnpx skills addthroughrunClientCommand(argv, with no shell on POSIX and escaped cmd.exe arguments on Windows) instead ofexecSync(args.join(' ')). It also passes--agentto the native no-npx fallback. This applies tosetup core/build/workflows/<skill>too, which share this path. A test checks that a hostile--agentvalue reaches npx as a single argument.This overlaps with the stale #226 (move from
beta-skills/toskills/). That move already shipped in #271, but the install wiring didn't come with it.firecrawl inithas its ownexecSyncskills path, which this PR leaves alone.