fix(rtdb): percent-encode special characters in query values - #992
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Query._querystr joined the JSON-encoded query values into the query
string as-is, so values containing characters with a special meaning in
a URL were not sent as written: equal_to('+15555555') reached the
server as " 15555555", equal_to('C#') cut the query at the '#' (dropping
orderBy), and '&' or '=' split the value into another parameter.
These characters are now percent-encoded.
There was a problem hiding this comment.
Code Review
This pull request introduces percent-encoding for special characters (such as '#', '%', '&', '+', '=', and '?') in Firebase Realtime Database query string values to ensure they are correctly transmitted. It defines a set of safe characters and uses urllib.parse.quote to encode the values. Additionally, a comprehensive set of unit tests has been added to verify the encoding behavior. There are no review comments, and we have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query._querystr joined the JSON-encoded query values into the query string as-is, so values containing characters with a special meaning in a URL were not sent as written: equal_to('+15555555') reached the server as " 15555555", equal_to('C#') cut the query at the '#' (dropping orderBy), and '&' or '=' split the value into another parameter. These characters are now percent-encoded.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.