Repository navigation
INTER-2456: Support tags option and deprecate tag - #216
Merged
Merged
Conversation
kevinmia
requested review from
JuroUhlar,
TheUnderScorer,
ilfa and
mcnulty-fp
as code owners
October 23, 2026 01:14
Contributor
Coverage report
Test suite run success43 tests passing in 15 suites. Report generated by 🧪jest coverage report action from 18361f6 Show full coverage report
|
kevinmia
force-pushed
the
chore/INTER-2456-standardize-tags
branch
from
October 23, 2026 01:20
dcfeea8 to
f8764cb
Compare
3 tasks done
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The supplied changes have no identified blocking issues, but the large lockfile change described in the PR remains unreviewed.
No open issues 🎉
What changed in this PR
This PR adds tags support to the React SDK while preserving the deprecated tag option, aligning the SDK with the agent’s tagging API.
Changes:
- Include
tagsin cache keys, with regression tests for request deduplication and automatic refetching. - Require
@fingerprint/agentversion^4.1.6. - Update documentation and the sign-in example to use
tags, and add a minor-release changeset.
| File | Description |
|---|---|
src/utils/get-options-cache-key.ts |
Include tags in request cache keys. |
README.md |
Document tags, legacy tag support, and precedence. |
package.json |
Raise the minimum agent version to 4.1.6. |
examples/create-react-app/src/shared/pages/SignInPage.tsx |
Switch the sign-in form to tags. |
.changeset/tags-option-support.md |
Record the feature for a minor release. |
__tests__/use-visitor-data.test.tsx |
Test deduplication and refetching with different tags. |
Review effort: Balanced
TheUnderScorer
previously approved these changes
Oct 23, 2026
TheUnderScorer
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left just one suggestion, thanks!
JuroUhlar
previously approved these changes
Oct 23, 2026
kevinmia
dismissed stale reviews from JuroUhlar and TheUnderScorer
via
October 23, 2026 16:21
18361f6
Contributor
JuroUhlar
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR as a part of INTER-2456. We're looking to standardize usage of
tagsacross SDKs. We will ensure thattagkeeps working, andtagswins if both are passed.The lockfile change is pretty large, but the only change from this PR is
@fingerprint/agent4.1.2 → 4.1.6. The rest is explained in the PR description in #214. Whichever of the two merges second will need to regenerate the lockfile.Changes:
@fingerprint/agent4.1.6 or later sotagsis inGetOptionstagsto the options cache key. Without it, changingtagsdidn't trigger a new request and calls with differenttagswere deduplicatedcreate-react-appexample to usetags, with a note thattagis deprecatedTesting:
tagstriggers a new request, and calls with differenttagsaren't deduplicated. Both failed before the fixtagtests still passcreate-react-app,nextandnext-appDirexamples locally