Skip to content

ci: skip e2e tests when only markdown files change - #291

Merged
TheUnderScorer merged 1 commit into
mainfrom
ci/disable-e2e-tests-for-md-changes
Oct 26, 2026
Merged

TheUnderScorer merged 1 commit into
mainfrom
ci/disable-e2e-tests-for-md-changes

Conversation

@TheUnderScorer

Copy link
Copy Markdown
Contributor

Summary

E2E tests (Android/iOS × 4 RN versions + web) ran on every PR, including docs-only ones. This skips them when a PR changes only .md files, while keeping a required check that always reports.

  • New changes job lists PR files via the GitHub API; code=false only if every file ends in .md. Non-PR events (release) always get code=true.
  • build-matrix and e2e-tests-web run only when code == 'true'; Android/iOS build + test jobs skip transitively.
  • New E2E Tests result aggregator job (if: always()): fails if changes failed or any E2E job failed/cancelled; passes on success/skipped.

Why not paths-ignore / plain if:

  • paths-ignore stops the workflow from starting, so required checks stay "Expected" forever.
  • Skipped matrix jobs report a single check with an unexpanded name (... ${{ matrix.react-native }}), so per-version required checks would never resolve.

⚠️ Required before merge

A repo admin must update the main branch rules: replace the per-matrix E2E required checks with E2E Tests result.

Test plan

  • This PR (workflow change) runs full E2E; E2E Tests result is green
  • A markdown-only PR: build/test jobs skipped, E2E Tests result green, PR mergeable

Generated by Claude Code

Add a `changes` job that detects whether a PR touches any non-markdown
file and skip the E2E build/test jobs when it does not. Add a single
`E2E Tests result` aggregator job that always reports, so branch rules
can require it instead of the per-matrix checks (skipped matrix jobs
never report their expanded check names).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015mG5hz7QECVCqv3AWMY1fi
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 91.35% 243/266
🟢 Branches 87.55% 211/241
🟢 Functions 84.21% 48/57
🟢 Lines 90.98% 232/255

Test suite run success

95 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from 36e2590

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 91.35 87.55 84.21 90.98
🟢  src 91.35 87.55 84.21 90.98
🟢   FingerprintClient.ts 100 90 100 100 22,41,54
🔴   FingerprintClient.web.ts 0 0 0 0 6-64
🟡   FingerprintContext.ts 66.66 100 0 66.66 6
🟢   FingerprintProvider.tsx 100 100 100 100
🟡   errors.ts 75 50 50 75 3,120
🟢   getOptionsCacheKey.ts 84 83.33 100 83.33 10,33,43,52
🔴   index.ts 0 0 0 0
🟢   tags.ts 95 94.44 100 95 31
🔴   types.ts 0 0 0 0
🟢   unwrapError.ts 100 88.46 100 100 18-19,40
🟢   unwrapError.web.ts 100 100 100 100
🔴   useFingerprint.ts 0 0 0 0 24-28
🟢   usePromiseStore.ts 100 100 100 100
🟢   useVisitorData.ts 95.91 85.71 90 95.74 166-167
🟢   utils.ts 98.57 97.36 90 98.48 10
🔴  src/specs 0 0 0 0
🔴   NativeRNFingerprint.ts 0 0 0 0

@TheUnderScorer
TheUnderScorer merged commit f3201e8 into main Oct 26, 2026
31 checks passed
@TheUnderScorer
TheUnderScorer deleted the ci/disable-e2e-tests-for-md-changes branch October 26, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants