Skip to content

chore(sdk): stop tracking sdk/README.md copy - #290

Merged
JuroUhlar merged 1 commit into
mainfrom
fix/untrack-sdk-readme
Oct 26, 2026
Merged

JuroUhlar merged 1 commit into
mainfrom
fix/untrack-sdk-readme

Conversation

@JuroUhlar

Copy link
Copy Markdown
Contributor

Context

Failed Release run after #288

Why

The Release workflow fails at changeset status and never publishes v4.2.0, because the build overwrites a stale, committed sdk/README.md, and that change inside the sdk package counts as a change with no changeset.

Things to note

Verification

Locally, after running the build's cp README.md sdk/README.md:

  • Before: changeset status → Some packages have been changed but no changesets were found
  • After: git status stays clean, and changeset status → NO packages to be bumped

Not verified yet: the Release run on main after this merges, which should publish 4.2.0.

Change outline

 # .gitignore — the entry never matched because of its case
-sdk/README.MD
+sdk/README.md
  sdk/LICENSE

 # git index
-sdk/README.md   # stale copy of ../README.md

Generated by Claude Code

The build copies the root README into sdk/. The committed copy went
stale, so the copy dirtied the sdk package and changeset status failed
in the Release workflow. Fix the .gitignore entry's case so the copy
stays ignored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F9FmJg2Q1koTtimNRAnyfP
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 91.35% 243/266
🟢 Branches 87.55% 211/241
🟢 Functions 84.21% 48/57
🟢 Lines 90.98% 232/255

Test suite run success

95 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from e9f1764

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 91.35 87.55 84.21 90.98
🟢  src 91.35 87.55 84.21 90.98
🟢   FingerprintClient.ts 100 90 100 100 22,41,54
🔴   FingerprintClient.web.ts 0 0 0 0 6-64
🟡   FingerprintContext.ts 66.66 100 0 66.66 6
🟢   FingerprintProvider.tsx 100 100 100 100
🟡   errors.ts 75 50 50 75 3,120
🟢   getOptionsCacheKey.ts 84 83.33 100 83.33 10,33,43,52
🔴   index.ts 0 0 0 0
🟢   tags.ts 95 94.44 100 95 31
🔴   types.ts 0 0 0 0
🟢   unwrapError.ts 100 88.46 100 100 18-19,40
🟢   unwrapError.web.ts 100 100 100 100
🔴   useFingerprint.ts 0 0 0 0 24-28
🟢   usePromiseStore.ts 100 100 100 100
🟢   useVisitorData.ts 95.91 85.71 90 95.74 166-167
🟢   utils.ts 98.57 97.36 90 98.48 10
🔴  src/specs 0 0 0 0
🔴   NativeRNFingerprint.ts 0 0 0 0

@JuroUhlar
JuroUhlar enabled auto-merge October 26, 2026 13:13
@JuroUhlar
JuroUhlar merged commit f68e992 into main Oct 26, 2026
29 checks passed
@JuroUhlar
JuroUhlar deleted the fix/untrack-sdk-readme branch October 26, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants