Repository navigation
fix: stale navigation check must not blank the current view (1.0.9) - #25
Merged
Merged
Conversation
…ks the current view _switch() went straight to _go() for known paths without a new token, so an older pending check (e.g. dead E:) stayed "current" and its failure/timeout replaced the C: view with "Laufwerk nicht erreichbar". Each navigation now takes exactly one new token, and _show_unreachable() ignores paths that are neither current nor pending. Tests: stale error / stale timeout (red on e1c4608, green now). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LYHP4Js5ggpzQ78JXWRe5E
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
Collaborator
Author
|
Review (Zwei-Modell-Regel): Claude Opus 5.5 als Operator. Ursache (bekannte Pfade erhöhten _nav_token nicht → späte Fehlprüfung eines alten Ziels leerte die aktuelle Ansicht) und Fix geprüft: ein Token je Navigation in _switch vor beiden Zweigen, Schutzbedingung in _show_unreachable. Neue Tests rot→grün, test_drive_switch 13/13, Suite 573 passed (1 bekannter hostbedingter Ausreißer), CI 14/14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Late failure/timeout of an earlier target (e.g. E:) switched the view the user had moved on to (C:) to 'Laufwerk nicht erreichbar'. Fix: one new nav token per navigation + guard in _show_unreachable. Tests: 2 new (red on e1c4608). Suite: 573 passed, 1 known host outlier (test_four_stalled_reads).
🤖 Generated with Claude Code
https://claude.ai/code/session_01LYHP4Js5ggpzQ78JXWRe5E