Skip to content

Fix OneHotEncoder metadata dropping generated indicators (#1106) #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avinashtrivedix wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix OneHotEncoder metadata dropping generated indicators (#1106) #1107

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca497af
Fix OneHotEncoder metadata dropping generated indicators (#1106)
avinashtrivedix Oct 17, 2026
2a64d22
Fix flake8 trailing whitespace and newline and remove trailing whites…
avinashtrivedix Oct 18, 2026
cc90385
Remaining flake8 whitespace on 313 and 315
avinashtrivedix Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature_engine/encoding/one_hot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def _get_new_features_name(self) -> List:

def _add_new_feature_names(self, feature_names) -> List:
"""Adds new features to df columns, and removes categoricals."""
feature_names = feature_names + self._get_new_features_name()
feature_names = [f for f in feature_names if f not in self.variables_]
feature_names = feature_names + self._get_new_features_name()

return feature_names