Famedly release/v1.162 - #27
Merged
Merged
Conversation
* Fix regression introduced in matrix-org#872 * Review comment * Fix CI now bullseye is dead
Bumps the minor-and-patches group with 1 update: [zizmorcore/zizmor-action](https://github.com/zizmorcore/zizmor-action). Updates `zizmorcore/zizmor-action` from 0.6.2 to 0.6.3 - [Release notes](https://github.com/zizmorcore/zizmor-action/releases) - [Commits](zizmorcore/zizmor-action@3dc1ecc...70fb788) --- updated-dependencies: - dependency-name: zizmorcore/zizmor-action dependency-version: 0.6.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patches ... Signed-off-by: dependabot[bot] <support@github.com>
…matrix-org#914) Null is not interoperable as an allowable field value: > Servers MAY reject null values. — https://spec.matrix.org/v1.19/client-server-api/#put_matrixclientv3profileuseridkeyname
…d-patches group (matrix-org#918) Signed-off-by: dependabot[bot] <support@github.com>
…ctions/minor-and-patches-8280b51821 Bump zizmorcore/zizmor-action from 0.6.2 to 0.6.3 in the minor-and-patches group
matrix-org#920) The two messages that are expected to highlight Bob only contained his user ID in the body text. That relies on the legacy push rules `.m.rule.contains_user_name` / `.m.rule.contains_display_name`, which Matrix v1.17 removes (MSC4210). Synapse disables them by default from 1.161.0 (element-hq/synapse#20220), so the test fails there with `highlight_count: 0`. Add an `m.mentions` block to both messages so they are highlighted via `.m.rule.is_user_mention` (Matrix v1.7). The expected counts are unchanged: a message with `m.mentions` produces exactly one highlight whether or not the legacy rules are enabled.
…ail (matrix-org#921) * bugfix: fix a federation connection leak which could cause tests to fail If you have a low fd limit (e.g. 256) then some test packages which do lots of federation requests from test -> server could result in the limit being reached due to there being a ton of HTTP transports each with a few idle connections because we did not reuse transports between HS names. This would result in obscure errors like "Invalid request signature" because the /key/server request was failing. * Review comments
Bumps the minor-and-patches group with 3 updates: [github.com/moby/moby/api](https://github.com/moby/moby), [github.com/moby/moby/client](https://github.com/moby/moby) and [golang.org/x/crypto](https://github.com/golang/crypto). Updates `github.com/moby/moby/api` from 1.55.0 to 1.56.0 - [Release notes](https://github.com/moby/moby/releases) - [Commits](moby/moby@api/v1.55.0...api/v1.56.0) Updates `github.com/moby/moby/client` from 0.5.1 to 0.6.0 - [Release notes](https://github.com/moby/moby/releases) - [Changelog](https://github.com/moby/moby/blob/v0.6.0/CHANGELOG.md) - [Commits](moby/moby@v0.5.1...v0.6.0) Updates `golang.org/x/crypto` from 0.55.0 to 0.56.0 - [Commits](golang/crypto@v0.55.0...v0.56.0) --- updated-dependencies: - dependency-name: github.com/moby/moby/api dependency-version: 1.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patches - dependency-name: github.com/moby/moby/client dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patches - dependency-name: golang.org/x/crypto dependency-version: 0.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patches ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ix-org#796) Update MSC4311 tests to conform to the spec. MSC4311 states that the client API should still use the stripped state event format. For the federation API, it should use full PDU's. MSC4311 also requires the `m.room.create` event be included in the list of stripped state. ["Stripped state"](https://spec.matrix.org/v1.18/client-server-api/#stripped-state) is a generic term that refers to simplified slice of state shared in `invite_room_state`/`knock_room_state` (`invite_state`/`knock_state` with `/sync`) before someone is joined to a room and can see the full room state. This PR was originally authored by @turt2live taking a stab at fixing single the flawed test (self-reported: ~~"I have no idea what I'm doing" disclaimer goes here~~) but has since been taken over by @MadLittleMods. And has naturally evolved some new better test coverage as I've worked on a full solution. Synapse PR: ~~element-hq/synapse#18822 element-hq/synapse#19723 The previous tests passed because of a flawed implementation in Synapse which is being removed in element-hq/synapse#19723 as well.
jason-famedly
approved these changes
Oct 2, 2026
jason-famedly
left a comment
jason-famedly
left a comment
Member
There was a problem hiding this comment.
I re-ran the test that failed before, as I suspected it only failed because it started running before the paired branch on Synapse had not been uploaded yet. Everything is green, so I have no issues!
🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.