Repository navigation
fix(js/ts/python/dart/beam): raise typed exceptions from invalidArg and invalidOp - #5152
Open
leonitousconforti wants to merge 1 commit into
Open
leonitousconforti wants to merge 1 commit into
leonitousconforti wants to merge 1 commit into
Conversation
…nd invalidOp `invalidArg` and `invalidOp` threw a plain `Exception`, so `:? ArgumentException` and `:? InvalidOperationException` handlers never caught them, nor the library errors raised through them. They now go through `FSharp.Core.Operators` like `nullArg`, raising the `System` exceptions the libraries already define. Beam tags its exception maps inline, as it does for those exceptions' constructors.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalidArgandinvalidOpcompile to a plainExceptionon every target, so:? ArgumentExceptionand:? InvalidOperationExceptionhandlers never catch them, or the library errors raised through them (Array.init -1,List.item,Seq.headon an empty sequence, ...).Each library already defines these
Systemexceptions, andnullArgalready raisesArgumentNullExceptionthroughFSharp.Core.Operators. This routesinvalidArgandinvalidOpthe same way on JS/TS, Python and Dart. Beam builds its tagged exception map inline, as it does for those exceptions' constructors. Messages don't change.Rust is unchanged, since it can't type-test BCL exceptions yet.
With the types visible,
List.takeandSeq.takeraiseArgumentExceptionwhere .NET raisesInvalidOperationException, andList.reducethe reverse. I left those for a follow-up.The full CI passes on my fork: https://github.com/leonitousconforti/Fable/actions/runs/39982396840. I also ran the JS output under JavaScriptCore: a repro matches .NET for all of the above, and a library's JS suite that catches these by type passes in full.