Repository navigation
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Thoth.Json.Python 0.7.0 update adds
codec.py, exposing two Pyright errors where byte and uint16 encoders pass their original values to a method expecting uint32. The F# source explicitly converts these values, but Python's numeric replacements discard widening conversions and retain the source wrapper. This also lets subsequent operations use the wrong integer width.Construct the target numeric type when widening, preserving both the runtime type and arithmetic width. Add regressions for sbyte-to-int16, byte-to-uint16, byte-to-uint32, and uint16-to-uint32 conversions. The generated codec remains covered by Pyright without adding an exclusion.