fix: type find/first/get as any when they can return nil - #992
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
find/findLast/findIndex/findLastIndex/first/last/get can return nil. Typing them as the element (or int) let AsInt+WarnOnAny accept expressions that then fail at Run with int(<nil>). Type them as any so WarnOnAny catches the mismatch, matching find over []any. Fixes expr-lang#989
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find, findIndex, first and get can return nil, but the type checker treated them as the element type (or int). With AsInt + WarnOnAny that compiles and then blows up at Run with int(). find over []any already failed the check because the element type is any.
Type those builtins as any so WarnOnAny catches them the same way. Field access and arithmetic on the result still type-check.
Fixes #989