fix(parser): fail fast on rules that don't advance state (infinite loop guard) - #443
Open
inchang-ing wants to merge 1 commit into
Open
inchang-ing wants to merge 1 commit into
inchang-ing wants to merge 1 commit into
Conversation
…op guard) Port markdown-it JS's guard (since 13.0.2): raise RuntimeError when a block/inline rule reports a match without advancing state.line / state.pos, instead of looping forever and exhausting memory. A buggy plugin rule that returns True without advancing made parse() hang indefinitely (e.g. texmath/amsmath plugin bugs, mdit-py-plugins#156 and executablebooks#117). Built-in rules always advance, so this only affects already broken plugins, which now fail with a clear message. Fixes executablebooks#441.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@e:/zcode-PR/.trash/pr-body-markdown-it-py-441.md