Repository navigation
fix: route sibling RFP links correctly - #46
Closed
arunimshukla wants to merge 1 commit into
Closed
arunimshukla wants to merge 1 commit into
arunimshukla wants to merge 1 commit into
Conversation
arunimshukla
requested review from
cygnusv,
oskarth and
rymnc
as code owners
September 28, 2026 05:39
arunimshukla
force-pushed
the
fix/rfp-sibling-links
branch
from
September 28, 2026 18:28
f64471d to
bf9bedd
Compare
rymnc
pushed a commit
that referenced
this pull request
Oct 5, 2026
Cherry-picks #46 (sibling RFP links), #47 (continuation-line glossary definitions), and #48 (Custom UTXO link to Shielding), preserving @arunimshukla as commit author. Clean picks onto main; tests pass (62/62). Prompted by: ac --------- Co-authored-by: Arunim Shukla <54760103+arunimshukla@users.noreply.github.com>
Member
|
thank you @arunimshukla, merged in 3330621 |
rymnc
added a commit
that referenced
this pull request
Oct 21, 2026
…nd feedback from ethlabs (#46) This pull request updates the post `src/posts/2026-10-19-upcoming-eips.md` to provide more accurate data, clearer explanations, and improved guidance regarding the upcoming Ethereum forks, especially Glamsterdam. The changes focus on updating transaction replay results, clarifying the impact on gas limits and costs, and expanding the discussion of future consensus improvements. **Major content updates:** *Replay and gas limit updates:* - Updated the transaction replay analysis to use 255 mainnet transactions (up from 86), with 209 of 255 failing under Glamsterdam when sent with their original gas limits. The table of replayed transactions now links to the actual transactions and includes more examples and details. - Clarified that transactions with pre-Glamsterdam gas limits are likely to fail after the fork, emphasizing the need to update gas limits in gateways and custody signing policies before December. [[1]](diffhunk://#diff-331671131a86238f1d7e85382d7bf6f3f5f3a2bcbafe044c14035dd5eeede4a7L86-R88) [[2]](diffhunk://#diff-331671131a86238f1d7e85382d7bf6f3f5f3a2bcbafe044c14035dd5eeede4a7L250-R259) *Cost and scenario clarifications:* - Improved the explanation of cost scenarios, separating them from the main text and making them easier to follow. *Consensus and finality roadmap:* - Expanded the discussion of future consensus changes, specifying that a new consensus model is expected to cut finality times to 4 minutes or less in the fork following Hegotá, and updated related summaries and figure captions. *General improvements:* - Added a thank-you note to EthLabs for their feedback on the post.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed bare sibling links between RFP pages resolving to
/use-cases/...instead of/rfps/....RFP source files use valid same-directory links such as
rfp-trust-assurance.md. Because RFPs are intentionally outside the graph and the bare filename has no directory component, the renderer previously fell through to the first empty-prefix content type and produced a use-case route.The change:
rfp-*.mdlinks before graph candidate matching/rfps/<slug>/pagesValidation
I reproduced the incorrect routing for the four affected RFP targets and verified the fix against all seven current sibling-link occurrences in the map content.
Regression coverage includes:
The branch is a single commit and changes only
src/lib/render.tsandtests/render-links.test.ts.