Skip to content

fix: remove unresolved Private DvP placeholder #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rymnc merged 2 commits into from
Oct 13, 2026
Merged

fix: remove unresolved Private DvP placeholder #203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
880fa6a
fix: remove unresolved Private DvP placeholder
arunimshukla Sep 25, 2026
0282e1e
docs: complete Trading use cases and approaches
arunimshukla Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions domains/trading.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,17 @@ description: "Execute and settle without leaking intent, size, or counterparties
- Cross-domain atomicity (DvP/PvP) without HTLCs; optional zk-SPV for strong atomicity.

## Primary use cases

@rymnc rymnc Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can link to private stablecoins here

@arunimshukla arunimshukla Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d use Private Repo instead of Private Stablecoins here.

  • private-repo.md is explicitly tagged primary_domain: Trading. private-stablecoins.md is tagged primary_domain: Payments. So the repo’s own taxonomy already puts Repo in the exact domain this page represents.

  • Private Repo is structurally closer to DvP because repo settlement is an asset-versus-cash transaction and the page already points to atomic settlement and DvP patterns.

  • Private Stablecoins are better understood as the cash part of a trade, not the trade use case itself. The stablecoin page supports settlement across multiple domains, especially Payments.

  • The Trading domain already has a separate “Related use cases” section. Stablecoins fit better there as supporting settlement infrastructure, while Repo fits naturally as a primary Trading use case.

  • Private Stablecoins are already a primary use case under Payments. Using it again as the main Trading entry weakens the taxonomy; using Private Repo keeps each domain anchored to a use case that actually belongs there.

If that makes sense, I’ll update the PR to link Private Repo here.

@cygnusv cygnusv Sep 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree Repo seems to fit better than Stablecoins here. Note, however, that Private Stocks and Private Commodities are also primary_domain: Trading, so all three should be listed rather than just Repo.

Having said that, there's the underlying question of how accurate current tags are. There may be some drift wrt existing knowledge and understanding. In particular, "Private DvP" already appears in the map as Approach: Atomic DvP Settlement (approaches/approach-dvp-atomic-settlement.md).
MAybe an Approaches section (like governance.md and identity-compliance.md) linking that approach and Private Trade Settlement can be interesting.

@arunimshukla arunimshukla Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I checked the current front matter and Trading has three primary use cases today:

  • Private Repo,
  • Private Stocks, and
  • Private Commodities,

so I’ll update the section to include all three.

I also checked the wider mapping and there does appear to be some taxonomy drift. Five use cases currently declare secondary_domain: Trading, Private FX, Private Read, Private Messaging, Private Corporate Bonds, and Private Oracles, while domains/trading.md currently lists only Private Bonds under its secondary section. private-bonds.mditself does not declare Trading as a secondary domain.

I’ll keep this PR scoped to two concrete changes:

  1. Align the primary use-case list with the existing frontmatter.

  2. Add an Approaches section linking Atomic DvP Settlement and Private Trade Settlement, following the structure already used in governance.md and identity-compliance.md.

I can take the broader domain/use-case mapping as a separate follow-up once this is merged, rather than mixing a taxonomy cleanup into the current fix.

@rymnc rymnc Oct 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, sounds good!

- Private DvP (link missing)
- [Private Repo](../use-cases/private-repo.md)
- [Private Stocks](../use-cases/private-stocks.md)
- [Private Commodities](../use-cases/private-commodities.md)

## Related use cases (secondary)
- [Private Bonds](../use-cases/private-bonds.md)

## Approaches
- [Approach: Atomic DvP Settlement](../approaches/approach-dvp-atomic-settlement.md)
- [Approach: Private Trade Settlement](../approaches/approach-private-trade-settlement.md)

## Shortest-path patterns
- [Pre-trade privacy (Shutter/SUAVE)](../patterns/pattern-pretrade-privacy-encryption.md)
- [Atomic DvP via ERC-7573](../patterns/pattern-dvp-erc7573.md)
Expand All @@ -28,4 +34,4 @@ description: "Execute and settle without leaking intent, size, or counterparties
- [Flashbots](../vendors/flashbots.md)
- [Shutter](../vendors/shutter.md)
- [Hinkal](../vendors/hinkal.md)
- [Orion Finance](../vendors/orion-finance.md)
- [Orion Finance](../vendors/orion-finance.md)
Loading