Repository navigation
Add script that writes types into js doc declarations - #201
Conversation
matthewmr-eqty
left a comment
matthewmr-eqty
left a comment
There was a problem hiding this comment.
Really nice. I built it and checked the hovers on Button, Badge, Card and ScrollArea, and all 181 exported components get a list. One small thing inline, not blocking.
matthewmr-eqty
left a comment
matthewmr-eqty
left a comment
There was a problem hiding this comment.
Really nice. I built it and checked the hovers on Button, Badge, Card and ScrollArea, and all 181 exported components get a list. One small thing inline, not blocking.
tmccoy14
left a comment
tmccoy14
left a comment
There was a problem hiding this comment.
The script runs cleanly in build:lib and documents 181 components, and the output is right for most of them. I left four inline comments: two cases where the hover is wrong or blank, one formatting inconsistency, and the missing tests.
Generated by Claude Code
|
Added tests and fixed the above issues. Also ran another round of Claude review and didn't find anything I deemed needed fixing. I think as a follow up it would be good to generate the props table in each mdx file based on this info and in-line all the comments too. Not doing in this PR but would be good for the future if we have some time :) |
3 participants
As much as I like our docs, I wish I didn't have to look at them as much :)
Changes