Repository navigation
Conversation
ale18V
marked this pull request as ready for review
October 10, 2026 14:11
ale18V
force-pushed
the
ci/selective-pr-checks
branch
from
October 20, 2026 11:16
4279373 to
50eeaf7
Compare
ale18V
changed the title
ale18V
force-pushed
the
ci/selective-pr-checks
branch
from
October 20, 2026 11:22
50eeaf7 to
555cc60
Compare
ale18V
force-pushed
the
ci/selective-pr-checks
branch
from
October 28, 2026 10:01
555cc60 to
d14d357
Compare
This reverts commit e829b7b.
JulienVig
requested changes
Oct 29, 2026
JulienVig
left a comment
JulienVig
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the refactor, overall I think it looks good! I just want to make sure that random forks can't trigger the publishing CD and that publishing runs stays ordered if they run in parallel.
| # When triggered by workflow_run, jobs only proceed if post-merge verification succeeded. | ||
| # The push condition allows release tags (v*) to publish immediately. | ||
| publish-npm: | ||
| if: github.event_name == 'push' || github.event.workflow_run.conclusion == 'success' |
Collaborator
There was a problem hiding this comment.
I think this job would get triggered by a fork PR with branch name main which would publish their code, we need to check that it's our repository too
| push: | ||
| # Deployments on main are chained to the verify workflow so they run only | ||
| # after post-merge verification succeeds on main, preventing deployment of broken commits. | ||
| workflow_run: |
Collaborator
There was a problem hiding this comment.
Maybe we should set a concurrency group to ensure that this workflow only runs one at a time so that concurrent runs can't rollback versions (if an older run finishes after the latest one)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
PR updates currently run the full verification suite even when a change only affects one package. This PR selects affected jobs on PRs, while running the complete suite on pushes to `main` (the after-merge event). A stable completion check (`complete`) reports failure when any selected verification job fails.
Additionally, the deployment workflow (`publish-deploy`) is updated to run only after the post-merge verification suite succeeds on `main`.
Technical plan
Deviations from plan
Replaced the merge queue with post-merge verification on `push` to `main` and chained CD via `workflow_run`.
Todo
Require the `complete` and `format-check` status checks in repository branch protection settings for `main`.