Repository navigation
fix: ModuleModel never frees its tree - #675
Open
horhulenko wants to merge 1 commit into
Open
horhulenko wants to merge 1 commit into
horhulenko wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModuleModelhad no destructor, so when one was destroyed, its root item and every item under it stayed in memory. On master, this happens every time the content of a grouping is shown and closed.The fix deletes the root item in
~ModuleModel, the same wayGatePinsTreeModelandModulePinsTreeModelalready do. It can't go intoBaseTreeModel:ModuleItemremoves itself from the model's maps when it's deleted, and those maps would already be gone by then.Memory left after showing and closing the content of 50 groupings of 1000 gates, 4 times in a row: