Repository navigation
Load the gate library parser before creating a new project - #655
Open
horhulenko wants to merge 2 commits into
Open
horhulenko wants to merge 2 commits into
horhulenko wants to merge 2 commits into
Conversation
The GUI loads parser plugins only on demand, but New Project called gate_library_manager::load without first loading the parser for the library's file type, so every attempt failed with "cannot load gate library". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
The same fix is needed to be able to create new project on Ubuntu 24.04. I've checked and the one-line change makes the work for Ubuntu too. |
joern274
previously approved these changes
Oct 20, 2026
joern274
left a comment
joern274
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this bug. Must admit that the create-new-netlist-from-scratch function is not used very often, so the bug went unnoticed for quite some time. I commend the swift fix and documentation in CHANGELOG
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was written by an AI coding assistant (Claude Code). The diagnosis, code change, changelog entry and this description were all produced by AI, and a human reviewed them before submission. Please review with that in mind.
Tested only on macOS: I ran into this issue on my Mac (arm64, Qt 6 from Homebrew) and have only tested the fix there. I have not tested this commit on Linux or on any other device.
Problem
Creating a project through New Project fails for every gate library with:
The GUI loads plugins only on demand. At startup,
GuiPluginManagerloads each plugin briefly to read its features and then unloads it, which also unregisters the.hglparser. Every other code path that loads a gate library first callsGuiPluginTable::loadFeature(FacGatelibParser, ext).FileManager::newProject()calledgate_library_manager::loaddirectly, so no parser was registered for the file type.Fix
Load the gate library parser for the selected library's extension in
FileManager::newProject()before loading the library, as the import and open paths already do. A changelog entry is added under GUI bugfixes.Testing
On macOS only: before the fix, New Project failed with the error above for
NanGate_15nm_OCL.hgl. After the fix, the project was created successfully. Not tested on other platforms.🤖 Generated with Claude Code