Repository navigation
export driver tags with unit - #2956
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 152205cc6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cmd.tags[i].name = strdup(data->tags[i].name); | ||
| cmd.tags[i].description = | ||
| strdup(data->tags[i].description ? data->tags[i].description : ""); | ||
| cmd.tags[i].unit = strdup(data->tags[i].unit ? data->tags[i].unit : ""); |
There was a problem hiding this comment.
Preserve units in global-config exports
When PUT /api/v2/global/config receives a non-empty tag unit, this line now preserves it in the live tag, but the corresponding GET path builds its response in get_tags_resp without assigning tags_res.tags[index].unit (the assignments at lines 1143-1151 omit it). neu_json_encode_tag consequently serializes the zero-initialized pointer as "", so the new nonempty round-trip assertion fails and exporting then re-importing the configuration silently clears the unit; copy tag->unit into the response tags in this sibling export path.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
+ Coverage 68.73% 68.85% +0.12%
==========================================
Files 135 137 +2
Lines 34411 34649 +238
==========================================
+ Hits 23653 23859 +206
- Misses 10758 10790 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.