Repository navigation
export driver tags with unit - #2955
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40d7b3da2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gdatatags[i].tags[j].bias = gtag_array->gtags[i].tags[j].bias; | ||
| gdatatags[i].tags[j].address = gtag_array->gtags[i].tags[j].address; | ||
| gdatatags[i].tags[j].name = gtag_array->gtags[i].tags[j].name; | ||
| gdatatags[i].tags[j].unit = gtag_array->gtags[i].tags[j].unit; |
There was a problem hiding this comment.
When PUT /api/v2/global/drivers supplies a unit longer than 128 characters, this new assignment carries it into persistence without any corresponding check in send_drivers(). The tags.unit constraint in persistence/0121_2.15.1_tag.sql rejects the insert, but adapter_storage_add_tags() only logs that failure while NEU_REQ_ADD_DRIVERS still replies with success, so after a restart the tag is missing (and a multi-tag transaction loses all tags in that group). Validate the optional unit before queuing the request so an invalid import cannot appear successful.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.16 #2955 +/- ##
==========================================
- Coverage 68.74% 68.74% -0.01%
==========================================
Files 135 135
Lines 34434 34439 +5
==========================================
+ Hits 23671 23674 +3
- Misses 10763 10765 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.