Repository navigation
Conversation
vize 0.17 replaces Vize.vapor_split/1 with Vize.split_template/2 and changes its error shape. Volt calls neither; the functions it uses (parse_sfc, compile_sfc, Vize.SFC.collect_template_assets and Vize.CSS) are unchanged, and the suite passes on 0.17.0. PhoenixVapor needs vize 0.17, and a Volt that pins ~> 0.16.0 cannot be installed alongside it. Volt follows vize's latest minor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the vize 0.17 requirement to the unpublished 0.20.0 release.
{:vize, "~> 0.17.0"}, lock moved to 0.17.0.vize 0.17 replaces
Vize.vapor_split/1withVize.split_template/2and changes that function's error shape. Volt calls neither. The functions it does use (parse_sfc,compile_sfc,Vize.SFC.collect_template_assets,Vize.CSS.*) are unchanged.PhoenixVapor needs vize 0.17, and published Volt 0.19.4 pins
~> 0.16.0, so the two cannot resolve together until this ships.Checked locally on vize 0.17.0:
mix test755 passed, browser tests 30 passed,mix lintpasses.