Repository navigation
fix: route siso clang-coverage rules through the cross-clang wrapper - #933
Merged
Merged
Conversation
With coverage_instrumentation_input_file set, Chromium's apple toolchain wraps every compile in clang_code_coverage_wrapper.py, so siso matches the clang-coverage/* rules instead of clang/*. On non-Linux hosts those rules got clang_mac.star's remote_wrapper but not the cross-clang wrapper, the Linux clang inputs, or the 10m remote timeout, so RBE failed with `fork/exec ../../buildtools/reclient_cfgs/chromium-browser-clang/clang_remote_wrapper: no such file or directory`. Treat clang-coverage/* like clang/* and clang-cl/* in both places. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhHDNf9qajjhk7SUKRR8EK
MarshallOfSound
approved these changes
Nov 18, 2026
claude Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Brings in #931 (siso weights) and #933 (clang-coverage cross-clang routing). e-build.ts: the siso spawn env now carries both GOGC=200 (siso.buildEnv) and SISO_WEIGHTS_FILE (weightsEnv) for every siso build, each with its own user overrides. main.star: keep #933's is_clang_rule alongside this branch's rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this when extending our code coverage CI workflow in electron/electron#55898.
This was validated by floating the same patch in electron/electron#55898, whose macOS coverage build passed.