Skip to content

fix: route siso clang-coverage rules through the cross-clang wrapper - #933

Merged
dsanders11 merged 1 commit into
mainfrom
fix/siso-clang-coverage-cross-wrapper
Nov 18, 2026
Merged

dsanders11 merged 1 commit into
mainfrom
fix/siso-clang-coverage-cross-wrapper

Conversation

@dsanders11

@dsanders11 dsanders11 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Ran into this when extending our code coverage CI workflow in electron/electron#55898.

This was validated by floating the same patch in electron/electron#55898, whose macOS coverage build passed.

With coverage_instrumentation_input_file set, Chromium's apple toolchain
wraps every compile in clang_code_coverage_wrapper.py, so siso matches
the clang-coverage/* rules instead of clang/*. On non-Linux hosts those
rules got clang_mac.star's remote_wrapper but not the cross-clang wrapper,
the Linux clang inputs, or the 10m remote timeout, so RBE failed with
`fork/exec ../../buildtools/reclient_cfgs/chromium-browser-clang/clang_remote_wrapper: no such file or directory`.

Treat clang-coverage/* like clang/* and clang-cl/* in both places.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VhHDNf9qajjhk7SUKRR8EK
@dsanders11
dsanders11 requested review from a team and ckerr as code owners November 18, 2026 07:03

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@dsanders11
dsanders11 merged commit f303f4c into main Nov 18, 2026
15 checks passed
@dsanders11
dsanders11 deleted the fix/siso-clang-coverage-cross-wrapper branch November 18, 2026 07:39
claude Bot pushed a commit that referenced this pull request Nov 18, 2026
Brings in #931 (siso weights) and #933 (clang-coverage cross-clang routing).
e-build.ts: the siso spawn env now carries both GOGC=200 (siso.buildEnv)
and SISO_WEIGHTS_FILE (weightsEnv) for every siso build, each with its own
user overrides. main.star: keep #933's is_clang_rule alongside this
branch's rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants