Repository navigation
feat: remote-execute Electron's local-only siso steps - #930
Draft
claude[bot] wants to merge 3 commits into
Draft
claude[bot] wants to merge 3 commits into
claude[bot] wants to merge 3 commits into
Conversation
Turn on siso remote execution by default, on Linux hosts with the DEPS python, for steps Chromium only remotes under its own configs: Rust compiles and build scripts, nasm, protoc, torque, Blink/DevTools python steps, an allowlist of hermetic python scripts, tsc and esbuild. Add handlers for pak_util's absolute allowlist path and for siso-written llvm-ar thin archives. `-config=electron-no-extras` opts out. `e build` also sets GOGC=200 for siso unless GOGC is already set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
MarshallOfSound
approved these changes
Nov 18, 2026
dsanders11
approved these changes
Nov 18, 2026
… allowlist path electron/electron#55870 makes repack's --allowlist path build-dir-relative, so the handler that rewrote the absolute path for remote execution is no longer needed. pak_util.py repack stays on the remote python allowlist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
Brings in #931 (siso weights) and #933 (clang-coverage cross-clang routing). e-build.ts: the siso spawn env now carries both GOGC=200 (siso.buildEnv) and SISO_WEIGHTS_FILE (weightsEnv) for every siso build, each with its own user overrides. main.star: keep #933's is_clang_rule alongside this branch's rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
Samuel Attard requested this in the #build-speed thread.
This turns on siso remote execution by default for Electron's build steps that currently run locally. That covers Rust rlib/staticlib compiles and build scripts, nasm, protoc, torque, the Blink and DevTools python steps, an allowlist of hermetic python scripts, and tsc and esbuild. It also adds a handler for llvm-ar thin archives. The new rules apply only on Linux hosts that use the DEPS-provided python, and
-config=electron-no-extrasturns them all off.e buildnow also sets GOGC=200 for siso unless GOGC is already set. On an 8-vCPU runner, a clean build with a warm cache went from about 380s and 2,840 CPU-s to about 150–168s and 1,000 CPU-s, and the outputs were byte-identical. A fulle buildhas since run with this exact tools/main.star (head 05a0168) on stock CIPD siso v1.6.9, using GOGC=200 and no -config, and two clean Electron builds took 188.7s and 183.6s with 0 failures, 0 local fallbacks and 0 remote retries. The companion Electron PRs are electron/electron#55868, #55869 and #55870. An earlier pak_util handler was removed because electron/electron#55870, which is merged to main with backports being raised, makes repack's allowlist path build-dir-relative.Generated by Claude Code