Skip to content

feat: remote-execute Electron's local-only siso steps - #930

Draft
claude[bot] wants to merge 3 commits into
mainfrom
claude/siso-remote-exec
Draft

claude[bot] wants to merge 3 commits into
mainfrom
claude/siso-remote-exec

Conversation

@claude

@claude claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Requested via Slack thread

Samuel Attard requested this in the #build-speed thread.

This turns on siso remote execution by default for Electron's build steps that currently run locally. That covers Rust rlib/staticlib compiles and build scripts, nasm, protoc, torque, the Blink and DevTools python steps, an allowlist of hermetic python scripts, and tsc and esbuild. It also adds a handler for llvm-ar thin archives. The new rules apply only on Linux hosts that use the DEPS-provided python, and -config=electron-no-extras turns them all off. e build now also sets GOGC=200 for siso unless GOGC is already set. On an 8-vCPU runner, a clean build with a warm cache went from about 380s and 2,840 CPU-s to about 150–168s and 1,000 CPU-s, and the outputs were byte-identical. A full e build has since run with this exact tools/main.star (head 05a0168) on stock CIPD siso v1.6.9, using GOGC=200 and no -config, and two clean Electron builds took 188.7s and 183.6s with 0 failures, 0 local fallbacks and 0 remote retries. The companion Electron PRs are electron/electron#55868, #55869 and #55870. An earlier pak_util handler was removed because electron/electron#55870, which is merged to main with backports being raised, makes repack's allowlist path build-dir-relative.


Generated by Claude Code

Turn on siso remote execution by default, on Linux hosts with the DEPS
python, for steps Chromium only remotes under its own configs: Rust
compiles and build scripts, nasm, protoc, torque, Blink/DevTools python
steps, an allowlist of hermetic python scripts, tsc and esbuild. Add
handlers for pak_util's absolute allowlist path and for siso-written
llvm-ar thin archives. `-config=electron-no-extras` opts out.

`e build` also sets GOGC=200 for siso unless GOGC is already set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
… allowlist path

electron/electron#55870 makes repack's --allowlist path build-dir-relative,
so the handler that rewrote the absolute path for remote execution is no
longer needed. pak_util.py repack stays on the remote python allowlist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
Brings in #931 (siso weights) and #933 (clang-coverage cross-clang routing).
e-build.ts: the siso spawn env now carries both GOGC=200 (siso.buildEnv)
and SISO_WEIGHTS_FILE (weightsEnv) for every siso build, each with its own
user overrides. main.star: keep #933's is_clang_rule alongside this
branch's rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KX1hkJiLW12nFkkahP1BKb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants