Repository navigation
HS-4407: Migrate CI to GitHub Actions - #50
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request removes the CircleCI configuration, updates the CI badge in the README to point to GitHub Actions, adds a new test:ci script in package.json, and refactors magic numbers into named constants in src/helpers/constants.ts. However, the GitHub Actions workflow file (.github/workflows/ci.yml) referenced in the README is missing from the pull request and needs to be added.
There was a problem hiding this comment.
🟡 Changes recommended
Publishing has an authentication-variable mismatch and allows releases from main despite the master-only requirement.
2 open findings
What changed in this PR
Migrates the library’s CI and npm publishing from CircleCI to GitHub Actions.
Changes:
- Adds cached installs, builds, unit tests, coverage reporting, and publishing.
- Replaces the CI badge and adds a dedicated CI test script.
- Names existing retry codes without changing their values.
| File | Description |
|---|---|
| src/helpers/constants.ts | Replaces numeric retry codes with named constants. |
| README.md | Switches the CI badge to GitHub Actions. |
| package.json | Adds the test:ci script. |
| .github/workflows/ci.yml | Adds build, test, reporting, and publishing jobs. |
| .circleci/config.yml | Removes the previous pipeline. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 73 82 +9
Branches 9 9
=========================================
+ Hits 73 82 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ddamico-ecobee
left a comment
There was a problem hiding this comment.
LGTM, if the short-lived token is the approach we are going with for now!


HS-4407: Migrate CI to GitHub Actions
Summary
masterusing repository secretsValidation
npm cinpm run buildnpx run test:ciThanks ❤️