Skip to content

HS-4407: Migrate CI to GitHub Actions - #50

Merged
vikram-ecobee merged 13 commits into
masterfrom
HS-4407
Oct 19, 2026
Merged

vikram-ecobee merged 13 commits into
masterfrom
HS-4407

Conversation

@vikram-ecobee

@vikram-ecobee vikram-ecobee commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

HS-4407: Migrate CI to GitHub Actions

Jira Ticket: HS-4407

utonagan

Summary

  • replace the CircleCI pipeline with GitHub Actions
  • run cached npm installs, builds, unit tests, coverage uploads, and Codecov reporting
  • publish to npm from successful pushes to master using repository secrets
  • update the README CI badge

Validation

  • npm ci
  • npm run build
  • npx run test:ci

Thanks ❤️

vikram-ecobee and others added 5 commits September 24, 2026 13:27
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the CircleCI configuration, updates the CI badge in the README to point to GitHub Actions, adds a new test:ci script in package.json, and refactors magic numbers into named constants in src/helpers/constants.ts. However, the GitHub Actions workflow file (.github/workflows/ci.yml) referenced in the README is missing from the pull request and needs to be added.

Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Publishing has an authentication-variable mismatch and allows releases from main despite the master-only requirement.

2 open findings
What changed in this PR

Migrates the library’s CI and npm publishing from CircleCI to GitHub Actions.

Changes:

  • Adds cached installs, builds, unit tests, coverage reporting, and publishing.
  • Replaces the CI badge and adds a dedicated CI test script.
  • Names existing retry codes without changing their values.
File Description
src/​helpers/​constants.ts Replaces numeric retry codes with named constants.
README.md Switches the CI badge to GitHub Actions.
package.json Adds the test:ci script.
.github/​workflows/​ci.yml Adds build, test, reporting, and publishing jobs.
.circleci/​config.yml Removes the previous pipeline.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6cadfa3) to head (4e17bcb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           73        82    +9     
  Branches         9         9           
=========================================
+ Hits            73        82    +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vikram-ecobee and others added 6 commits October 16, 2026 11:40
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@vikram-ecobee
vikram-ecobee marked this pull request as ready for review October 16, 2026 16:13
@vikram-ecobee
vikram-ecobee requested review from chrisc-ecobee, ddamico-ecobee and jesswoo-ecobee and a balanced review from Copilot October 16, 2026 16:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Node 20 dependency installation and authenticated npm publishing still need end-to-end runner validation.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

@ddamico-ecobee ddamico-ecobee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the short-lived token is the approach we are going with for now!

@vikram-ecobee
vikram-ecobee merged commit 3a663b7 into master Oct 19, 2026
6 of 7 checks passed
@vikram-ecobee
vikram-ecobee deleted the HS-4407 branch October 19, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants