Repository navigation
fix(core): store the new Ajv instance when handling setAjv - #2642
Open
gigibiffi84 wants to merge 1 commit into
Open
gigibiffi84 wants to merge 1 commit into
gigibiffi84 wants to merge 1 commit into
Conversation
The SET_AJV reducer compiled the schema with the new Ajv instance but never wrote it to state, so every later setSchema or re-enabled validation silently went back to the previous instance. Part of eclipsesource#1498 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
coverage: 84.762% (+0.2%) from 84.58% — gigibiffi84:fix/set-ajv-stores-instance into eclipsesource:master |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1498
What changed
The
SET_AJVreducer compiled the schema with the new Ajv instance but never stored that instance in state. Every latersetSchema, and re-enabling validation afterNoValidation, silently compiled with the previous instance again. The reducer now storesajv: action.ajv.For adopters
Nothing changes unless you dispatch
setAjv; if you do, the instance you pass is now actually used from then on.Tests
Three new cases in
packages/core/test/reducers/core.test.ts: the instance is stored, a latersetSchemacompiles with it, and re-enabling validation compiles with it. Full core suite green.🤖 Generated with Claude Code