Repository navigation
Enabled FVP execution in the ZoneX workflow - #12
Merged
Merged
Conversation
Fixes eclipse-threadx#6 zx_fvp only ran the FVP when a repository variable pointed it at the model, and none was set, so every run built the images and executed nothing. The workflow also expected an unpacked model, but Arm ships the FVP as an installer script. The workflow now downloads the 11.32_19 archive from Arm's public permalink, checks it against a pinned SHA-256, and runs Arm's installer with its EULA accepted. The cache is keyed on the checksum. A missing model now fails the job instead of skipping execution, and CTest fails if it finds no tests. CONTRIBUTING.md no longer describes the repository variable. The workflow's install, locate, and build-and-run steps, run locally as written against the pinned ThreadX commit, download and verify the archive, install 11.32+19, build 27 images and pass 24/24 on the FVP. check_terminology.sh and check_references.sh pass. Assisted-by: Claude Code (Opus 5.5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
zx_fvponly ran the FVP when a repository variable pointed it at the model, and none was set, so every run built the images and executed nothing. The workflow also expected an unpacked model, but Arm ships the FVP as an installer script.The workflow now downloads the 11.32_19 archive from Arm's public permalink, checks it against a pinned SHA-256, and runs Arm's installer with its EULA accepted. The model is fetched from Arm and never re-hosted, which Eclipse IT confirmed is not redistribution. The cache is keyed on the checksum. A missing model now fails the job instead of skipping execution, and CTest fails if it finds no tests.
CONTRIBUTING.mdno longer describes the repository variable. This is the same change as eclipse-threadx/threadx#806, which now executes the ThreadX Cortex-R52 suite on everydevpush.The workflow's install, locate, and build-and-run steps, run locally as written against the pinned ThreadX commit, download and verify the archive, install 11.32+19, build 27 images and pass 24/24 on the FVP.
check_terminology.shandcheck_references.shpass.