[damskii9992]

This PR changes the default variance on Parameter to None instead of 0.0, in line with our DescriptorNumber and DescriptorArray. It also fixes our Optional and Union typehinting issue.

[rozyczko]

Removal of Union and Optional in the same PR?? BAD CHRISTIAN, BAD!!

• parameter.py:160: still uses 0.0 in from_dependency. You didn't update default_kwargs = {'value': 0.0, 'variance': 0.0, ...}. Probably harmless but looks confusing.

• No test for the new default? Nothing checks that Parameter(1.0).variance is None or .error is None.

• Typing:
  DescriptorNumber.variance -> float, and .error -> float should be float | None.
  The setters variance_float: float and error(value: float), in both descriptor_number.py and parameter.py, accept None and shouldalso have correct typing.

[rozyczko]

As explained above

[damskii9992]

• parameter.py:160: still uses 0.0 in from_dependency. You didn't update default_kwargs = {'value': 0.0, 'variance': 0.0, ...}. Probably harmless but looks confusing.

This one is definitely harmless. As it gets overwritten immediately anyways, but I suppose I might as well change it. 🤷

[rozyczko]

Looks good now 👌
Still fuming about the drive-by removal of Optional but we need this be consistent in the code.