Repository navigation
Fix FTMS initialization for trainers with non-readable Training Status - #74
Open
fishbone-git wants to merge 2 commits into
Open
fishbone-git wants to merge 2 commits into
fishbone-git wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Bug #73.
The Elite Suito smart trainer fails to initialize because
MachineController.subscribe()attempts to read the FTMS Training Status characteristic (0x2AD3).The trainer rejects this operation with GATT error
0x02(Read Not Permitted), preventing initialization.Changes
Remove the initial Training Status characteristic read while retaining the notification subscription.
Hardware verification
Tested successfully with:
Before: FTMS initialization failed with
Read Not Permittedon GATT handle 40.After: Home Assistant FTMS integration initializes successfully and the trainer connects.
Compatibility consideration
Removing the initial read means that Training Status will be populated when the trainer sends a notification rather than immediately upon connection. This avoids initialization failures on devices that prohibit direct reads.