Repository navigation
Fixes #200: Apply fn/@underline to literal footnote callouts - #201
Open
ekimbernow wants to merge 2 commits into
Open
ekimbernow wants to merge 2 commits into
ekimbernow wants to merge 2 commits into
Conversation
fn/@underline is now applied to the literal callout run in both the footnote reference and the footnote itself when @callout is specified. The attribute is declared in the RNG grammar. Footnote text is not underlined by the attribute. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
|
Re scope: This depends on the footnote type. If it's a normal footnote then the scope can be inclusive (callout + footnote). But if it's a reference footnote then it must apply only to the callout. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Added a note to the RNG docs and README on using |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.
fn/@underlinewas ignored. It is now applied to the literal callout run, in both the body reference and the footnote, when@calloutis specified. The footnote text is not underlined by the attribute.DocxGenerator.makeFootnote(): read@underline; newsetCalloutUnderline()helper validates againstSTUnderline.simplewpml-base.rng: declarefn/@underline(same values asrun/@underline).testFootnoteCalloutUnderlinewithsimplewpml-issue-200-fn-underline.swpx.Scope (callout only vs. whole footnote) is still to be confirmed in the issue discussion.
Verified by regenerating
IFRS07.swpxand checking the rendering in Word: underlined callout "1" in both places, plain "2".🤖 Generated with Claude Code