Skip to content

Fixes #200: Apply fn/@underline to literal footnote callouts - #201

Open
ekimbernow wants to merge 2 commits into
developfrom
feature/200-fn-callout-underline
Open

ekimbernow wants to merge 2 commits into
developfrom
feature/200-fn-callout-underline

Conversation

@ekimbernow

Copy link
Copy Markdown
Collaborator

Fixes #200.

fn/@underline was ignored. It is now applied to the literal callout run, in both the body reference and the footnote, when @callout is specified. The footnote text is not underlined by the attribute.

  • DocxGenerator.makeFootnote(): read @underline; new setCalloutUnderline() helper validates against STUnderline.
  • simplewpml-base.rng: declare fn/@underline (same values as run/@underline).
  • Test testFootnoteCalloutUnderline with simplewpml-issue-200-fn-underline.swpx.
  • README release note.

Scope (callout only vs. whole footnote) is still to be confirmed in the issue discussion.

Verified by regenerating IFRS07.swpx and checking the rendering in Word: underlined callout "1" in both places, plain "2".

🤖 Generated with Claude Code

fn/@underline is now applied to the literal callout run in both the
footnote reference and the footnote itself when @callout is specified.
The attribute is declared in the RNG grammar. Footnote text is not
underlined by the attribute.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@drmacro
drmacro self-requested a review October 12, 2026 21:53
@drmacro drmacro self-assigned this Oct 12, 2026
@drmacro drmacro added bug Something isn't working enhancement New feature or request labels Oct 12, 2026
@rajko-furlan

Copy link
Copy Markdown
Collaborator

Re scope: This depends on the footnote type. If it's a normal footnote then the scope can be inclusive (callout + footnote). But if it's a reference footnote then it must apply only to the callout.
Think about it this way. The styling is there to indicate footnote changes (new or deleted). If you add a note then underline (i.e., new) must be applied to the callout and to the footnote. But if you add a reference then it must apply only to the callout as only the callout is new while the footnote is potentially there already. I'm not sure though now this actually works in Wordinator.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ekimbernow

Copy link
Copy Markdown
Collaborator Author

Added a note to the RNG docs and README on using fn/@underline for new footnotes vs. new references, per the discussion in #200.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fn/@underline not applied to footnote callouts

3 participants