Skip to content

imap4rev2: Allow and send UTF-8 in quoted strings - #1708

Open
mbettini-ox wants to merge 7 commits into
dovecot:mainfrom
mbettini-ox:DOV-7425
Open

mbettini-ox wants to merge 7 commits into
dovecot:mainfrom
mbettini-ox:DOV-7425

Conversation

@mbettini-ox

Copy link
Copy Markdown
Contributor

No description provided.

…fields_dropped

Cache purge drops legacy mime.parts entries once mime.parts.v2 exists
(DOV-7425); the count makes that reclaim visible per purge.
The setting exists since 2.4.2 but had no entry, so the UTF8=ACCEPT
notes could only name IMAP4rev2 without linking to how it is enabled.
The new cache fields are only written above the gate, so the rollback
rule and the cost of staying below it belong next to the setting.
FETCH and URLFETCH output differs per session for the same mail, and the
attachment keywords may appear for UTF-8 sessions only, which support
needs to be able to explain.
…che fields

DOV-7425 adds them for message/global support in UTF8=ACCEPT sessions.
Admins see them in doveadm dump and need to know that the cache field
settings keep working with the legacy names only.
Raising dovecot_storage_version switches the cache to mime.parts.v2, and
the upgrade page is where admins look for what a rollback can still read.
…ocumentation

imap4rev2_enable exists since 2.4.2; the mime.parts.v2 cache fields, the
storage version gate and the UTF8=ACCEPT notes are new in 2.4.6.
@github-actions

Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

BODYPARTSTRUCTURE

These words are not needed and should be removed FROP

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:mbettini-ox/documentation.git repository
on the DOV-7425 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.26/apply.pl' |
perl - 'https://github.com/dovecot/documentation/actions/runs/40540365105/attempts/1' &&
git commit -m 'Update check-spelling metadata'

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns.txt:

# Automatically suggested patterns

# hit-count: 6 file-count: 5
# base64 encoded content
([`'"])[-a-zA-Z=;:/0-9+]+=\g{-1}

Alternatively, if a pattern suggestion doesn't make sense for this project, add a # to the beginning of the line in the candidates file with the pattern to stop suggesting it.

Notices ℹ️ (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Notices Count
ℹ️ candidate-pattern 3

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant