Perf Tests | Default Config File

[benrr101]

Description

I got annoyed that my changes to the runnerconfig file kept getting blown away when I'd switch branches. We don't have this problem with the manual tests project despite it having a config file. So, I instructed the 🤖 to mirror the pattern in the perf tests project. This moves the runnerconfig.jsonc file to the runnerconfig.default.jsonc, and adds targets to the perf test project to use the default config as the live config (if it doesn't exist already) and copy the live config to the build output. It then adds the live config file as a gitignore, to deter accidentally committing one's DB credentials.

Issues

N/A

Testing

Perf test pipeline should be reran to ensure that the changes play nice.

[Copilot]

Pull request overview

Moves performance-test configuration to a generated, locally editable file.

Changes:

• Adds a default runner configuration template.
• Generates and copies the live configuration during builds.
• Documents and ignores the local configuration file.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
runnerconfig.default.jsonc	Provides the default configuration template.
Microsoft.Data.SqlClient.PerformanceTests.csproj	Generates and copies the live configuration.
BUILDGUIDE.md	Documents the new configuration workflow.
.gitignore	Excludes the local runner configuration.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

Review details

• Files reviewed: 10/11 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟢 Approval recommended

The updated scripts resolve the earlier clean-checkout ordering issue and include focused cross-shell coverage for config generation, redaction, and translation.

Review details

• Files reviewed: 11/12 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

[Copilot]

Copilot review overview

🟡 Changes recommended

The setup guide instructs users to edit the generated config before any build creates it.

Review effort: Balanced
Findings: 1 · 1

Open (2)

• This target runs too late for the performance pipelines. Both entrypoint scripts read the…
• Generate runner config before instructing users to edit it · New

[Copilot]

🔵 Needs a closer look

Cross-platform performance orchestration and external pipeline integration were inspected but not executed.

1 open finding

• Generate runner config before instructing users to edit it

1 resolved since last review

• This target runs too late for the performance pipelines. Both entrypoint scripts read the…

🧠 Review effort: Balanced

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.35%. Comparing base (c7ab087) to head (5697ba8).
⚠️ Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c7ab087) and HEAD (5697ba8). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (c7ab087)	HEAD (5697ba8)
CI-SqlClient	2	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
- Coverage   72.40%   65.35%   -7.05%     
==========================================
  Files         292      286       -6     
  Lines       45471    68600   +23129     
==========================================
+ Hits        32924    44835   +11911     
- Misses      12547    23765   +11218     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	65.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🔵 Needs a closer look

Cross-platform performance orchestration changed substantially, and only static inspection and Bash syntax validation were available.

1 open finding

• Generate runner config before instructing users to edit it

🧠 Review effort: Balanced