Skip to content

Use StructArmed on QA - #471

Open
samsonasik wants to merge 1 commit into
dotkernel:7.0from
samsonasik:use-structarmed-on-qa
Open

samsonasik wants to merge 1 commit into
dotkernel:7.0from
samsonasik:use-structarmed-on-qa

Conversation

@samsonasik

Copy link
Copy Markdown

This PR to make use of StructArmed.

This PR start apply StructArmed with initialize using PSR4 and CODEQUALITY preset. The CODEQUALITY fixes 22 violations:

- fn (RoleInterface $role): string => (string) $role->getName()->value,
+ static fn (RoleInterface $role): string => (string) $role->getName()->value,

applied with single command:

vendor/bin/structarmed analyze --fix

I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik

Copy link
Copy Markdown
Author

@arhimede ready for review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant