Skip to content

fix(router): preserve equals signs in query values - #2811

Open
xu91102 wants to merge 1 commit into
docsifyjs:developfrom
xu91102:fix/query-values-with-equals
Open

xu91102 wants to merge 1 commit into
docsifyjs:developfrom
xu91102:fix/query-values-with-equals

Conversation

@xu91102

@xu91102 xu91102 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Query values such as ?id=a=b=c were truncated to a, because parseQuery split at every equals sign and kept only the second part. Split out the entire remainder after the first equals sign so route queries preserve their values.

Fixes #2810.

Regression coverage includes multiple/lone equals signs, percent-encoded equals signs, plus-to-space decoding, empty values and valueless parameters.

Validation:

  • Confirmed the new regression fails on the original code and passes with the fix.
  • npm run test:jest -- --runInBand: 13 suites, 129 tests, 46 snapshots passed.
  • npm run typecheck: passed.
  • npm run build: passed.
  • Prettier and ESLint checks for changed files, plus git diff --check: passed.

Assisted by Codex; reviewed the complete diff and ran these checks locally. The full Playwright browser matrix was not run locally.

@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Docsify Team on Vercel.

A member of the Team first needs to authorize it.

@Koooooo-7 Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kinda corner case I suppose it is unnecessarily to introduce it for now.
But if it really does in future. We could consider it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query parameter values are truncated at a second equals sign

2 participants