Repository navigation
Conversation
"docker manifest annotate" ignored the --variant and --os-version flags when passed an empty value, making it impossible to remove a variant or OS version from a manifest entry. Apply these flags whenever they are set, so that an empty value unsets the field. Fixes docker#4352 Signed-off-by: Nimesh Kulkarni <167794819+GitNimay@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@thaJeztah @vvoland PTAL when you have a moment. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
docker manifest annotateonly applied--variantand--os-versionwhen the value was non-empty, so there was no way to remove a variant or OS version from a manifest entry. These flags are now applied whenever they are passed, so an empty value unsets the field. Not passing the flag keeps the existing value, as before.Before:
After:
- How I did it
Record whether
--variantand--os-versionwere set (cmd.Flags().Changed), and use that instead of a non-empty check.- How to verify it
The new
TestManifestAnnotateUnsetFieldstest fails without this change.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)