Repository navigation
cmd/docker-trust: Inline some cli dependencies - #7412
Merged
Merged
Conversation
The plugin only needed progress display and an auxiliary callback. Inlined that use while preserving cancellation and terminal handling. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Both entry points use NewRootCmd, which adds subcommands directly. Removed the unused registry registration and constructor. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
The plugin only used lazyregexp for two small, fixed name patterns. Replaced it with regexp.MustCompile without changing validation. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
AkihiroSuda
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/docker-trust: Inline the JSON stream display helper
The plugin only needed progress display and an auxiliary callback. Inlined that use while preserving cancellation and terminal handling.
cmd/docker-trust: Remove unused command registration
Both entry points use NewRootCmd, which adds subcommands directly. Removed the unused registry registration and constructor.
cmd/docker-trust: Use standard regexps for name validation
The plugin only used lazyregexp for two small, fixed name patterns. Replaced it with regexp.MustCompile without changing validation.