Skip to content

fix: flaky TestPrunePromptTermination test #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hirehamir wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: flaky TestPrunePromptTermination test #7168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eee041
fix: flaky `TestPrunePromptTermination` test
hirehamir Aug 7, 2026
3ea231b
drop `OutBuffer()` checks that are now unnecessary
hirehamir Oct 19, 2026
3f83a0c
fix identical issue in `internal/test/cmd.go`
hirehamir Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmd/docker-trust/internal/test/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ func TerminatePrompt(ctx context.Context, t *testing.T, cmd *cobra.Command, cli
}))
cli.SetOut(outStream)

r, _, err := os.Pipe()
r, w, err := os.Pipe()
assert.NilError(t, err)

// Keep the write end alive for the duration of the test.
defer w.Close()
cli.SetIn(streams.NewIn(r))

notifyCtx, notifyCancel := context.WithCancel(ctx)
Expand Down Expand Up @@ -58,8 +61,6 @@ func TerminatePrompt(ctx context.Context, t *testing.T, cmd *cobra.Command, cli
}()
}

assert.Check(t, cli.OutBuffer().Len() > 0)

// a small delay to ensure the plugin is prompting
time.Sleep(100 * time.Microsecond)

Expand Down
7 changes: 4 additions & 3 deletions internal/test/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ func TerminatePrompt(ctx context.Context, t *testing.T, cmd *cobra.Command, cli
}))
cli.SetOut(outStream)

r, _, err := os.Pipe()
r, w, err := os.Pipe()
assert.NilError(t, err)

// Keep the write end alive for the duration of the test.
defer w.Close()
cli.SetIn(streams.NewIn(r))

notifyCtx, notifyCancel := context.WithCancel(ctx)
Expand Down Expand Up @@ -58,8 +61,6 @@ func TerminatePrompt(ctx context.Context, t *testing.T, cmd *cobra.Command, cli
}()
}

assert.Check(t, cli.OutBuffer().Len() > 0)

// a small delay to ensure the plugin is prompting
time.Sleep(100 * time.Microsecond)

Expand Down
Loading