Repository navigation
Conversation
Return no Jaeger traces for empty input so history trace can report "no trace data" instead of panicking on the first span. Only add CHILD_OF references for valid parent contexts, avoiding zero-ID references on root spans while preserving valid parents and span links. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
|
Maybe we should just remove Jaeger support? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle empty traces without panicking during Jaeger conversion.
ParseSpanStubsaccepts empty or whitespace-only input, butJaegerDataunconditionally accesses the first span atbuildx/util/otelutil/jaeger.go
Lines 17 to 29 in c43f837
Return an empty result instead, allowing
buildx history traceto reach its existingno trace dataerror atbuildx/commands/history/trace.go
Lines 97 to 111 in c43f837
The new empty-input regression test reproduced the index-out-of-range panic before this fix. This confirms the conversion failure but doesn't establish that BuildKit currently produces empty trace blobs.
Only emit
CHILD_OFreferences for valid parent contexts. The previous conversion atbuildx/util/otelutil/jaeger/convert.go
Lines 117 to 129 in c43f837
This is visible in the existing
bakeroot-span fixture atbuildx/util/otelutil/fixtures/jaeger.json
Lines 7801 to 7811 in c43f837
Remove that invalid reference while preserving valid parents, span links, and their existing order. Roots without links now serialize with
"references": null, which the pinned Jaeger UI normalizes to an empty list.