Repository navigation
ci: wait for udev before checking KVM access - #6
Merged
Merged
Conversation
udevadm trigger returns before udev has applied the rule that opens /dev/kvm to the runner user, so the check right after it can fail on a runner that has KVM. The CLI smoke tests failed this way three times in a row on #5, while the integration tests, with the same step, passed. Wait for udev to settle, and list the device so that a runner without KVM shows as one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI smoke tests on #5 failed three times in a row in "Enable KVM", before any test ran. The integration tests, with the same step on the same runner image, passed.
udevadm triggerreturns before udev has applied the rule that opens/dev/kvmto the runner user, and the check ran about 30 ms after it.Both KVM jobs in
check-digdir.ymlnow wait withudevadm settlebefore the check, and list/dev/kvm, so that a runner without KVM shows as one instead of failing silently.Evidence
This PR's own checks run both jobs. If the smoke tests still fail, the
ls -l /dev/kvmoutput tells a missing device from a permission problem.