Repin @xterm/addon-serialize in pnpm bump:xterm - #966
Merged
Merged
Conversation
xterm-bump kept its own list of four addons, so the serialize addon lib and standalone added later stayed on the old core after a bump, and xterm-lint then rejected the set the script wrote. Read the addon list from lib/package.json instead. Co-Authored-By: Claude <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
14b46da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90af0f02.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-xterm-bump-serialize.mouseterm.pages.dev |
nedtwigg
requested a deployment
to
hosted-preview
October 3, 2026 15:52 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm bump:xtermleft@xterm/addon-serializebehind.scripts/xterm-bump.mjskept a hand-written list of four addons, and the serialize addon was added tolibandstandaloneafter the list was written. A bump therefore moved the core and four addons but kept serialize on the old core.scripts/xterm-lint.mjsthen rejected the set, even though the script's own peer check exists to refuse "a set xterm-lint would reject". The "already on the newest coherent set" check skipped serialize too.The script now reads its addon list from
lib/package.json: every@xterm/addon-*dependency. An addon added later is picked up without editing the script.xterm-lintalready keepsstandalone's pins identical tolib's.scripts/xterm-bump.test.mjsnow includes serialize in its fixture, plus a case where only serialize is stale. That case fails without the change. All 16 tests andnode scripts/xterm-lint.mjspass locally.