refactor(reader): one MaterializedArrays.of for the six ptype-to-array switches - #449
Merged
Merged
Conversation
…y switches Primitive, Zstd, Bitpacked, Delta, Patched and Dict each switched over ptype to wrap a decoded segment in its Materialized*Array. They now call the package-private MaterializedArrays.of, which covers every ptype. Bitpacked and Delta are integer-only in Rust, so each now rejects a floating ptype up front instead of relying on the old switch default. Patched loses its F16 rejection: Rust's Patched accepts every native ptype, so reading F16 there is a parity fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
refactor/materialized-array-factory
branch
from
October 3, 2026 20:24
8ffe7e1 to
af35159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primitive, Zstd, Bitpacked, Delta, Patched and Dict each switched over
ptype to wrap a decoded segment in its Materialized*Array. They now call
the package-private MaterializedArrays.of, which covers every ptype.
Bitpacked and Delta are integer-only in Rust, so each now rejects a
floating ptype up front instead of relying on the old switch default.
Patched loses its F16 rejection: Rust's Patched accepts every native
ptype, so reading F16 there is a parity fix.
Verified with
./mvnw verify(unit + integration).🤖 Generated with Claude Code